Weapons do not longer merge in shifter forms

Report any bugs you find here.
Post Reply
User avatar
Iwan
Knight
Knight
Posts: 25
Joined: Thu Jan 17, 2019 10:08 am

Weapons do not longer merge in shifter forms

Post by Iwan »

Hello. After last restart weapons stopped merging in shifter forms.
User avatar
driller
Site Admin
Site Admin
Posts: 4793
Joined: Tue Jul 04, 2006 8:52 am
Contact:

Re: Weapons do not longer merge in shifter forms

Post by driller »

I noticed this during testing. This is a timing issue, I added a delay to give time for the creature items to be created and equipped. Evidently, this wasn't enough. I will have to change it to a recursive function that keeps checking to see if the items are valid before adding the properties.
User avatar
Iwan
Knight
Knight
Posts: 25
Joined: Thu Jan 17, 2019 10:08 am

Re: Weapons do not longer merge in shifter forms

Post by Iwan »

Ok. Thank You for your efforts.
John-Alhoon
Commoner
Commoner
Posts: 11
Joined: Wed Dec 19, 2018 7:34 pm

Re: Weapons do not longer merge in shifter forms

Post by John-Alhoon »

Thanks for the quick resolution!
User avatar
Cornflower
Duke
Duke
Posts: 654
Joined: Sat May 26, 2018 10:53 am
Location: Sweden

Re: Weapons do not longer merge in shifter forms

Post by Cornflower »

driller wrote: Wed Jan 23, 2019 9:32 am I noticed this during testing. This is a timing issue, I added a delay to give time for the creature items to be created and equipped. Evidently, this wasn't enough. I will have to change it to a recursive function that keeps checking to see if the items are valid before adding the properties.
Ouch. Recursive functions can be nasty. I am convinced you already thought of this, but even so: there needs to be some kind of anti-loop-security in that function, so that if it goes out of whack, it won't crash the server.
Who wills, can
Who tries, does
Who loves, lives
(Ann McCaffrey)
User avatar
driller
Site Admin
Site Admin
Posts: 4793
Joined: Tue Jul 04, 2006 8:52 am
Contact:

Re: Weapons do not longer merge in shifter forms

Post by driller »

I always add a safety variable that will exit if it goes over a certain number.
Cornflower wrote: Fri Jan 25, 2019 7:04 am
driller wrote: Wed Jan 23, 2019 9:32 am I noticed this during testing. This is a timing issue, I added a delay to give time for the creature items to be created and equipped. Evidently, this wasn't enough. I will have to change it to a recursive function that keeps checking to see if the items are valid before adding the properties.
Ouch. Recursive functions can be nasty. I am convinced you already thought of this, but even so: there needs to be some kind of anti-loop-security in that function, so that if it goes out of whack, it won't crash the server.
Post Reply